Conversation
This commit changes the project's build scripts to target Minecraft 26.1 (instead of 1.21.1). No mod code has been changed, so this won't compile as-is.
This does not include data generation, so the mod still doesn't compile yet. Additionally, there are a few ambiguities I've left as TODOs.
I had to totally rewrite the mod's model data providers since 26.1 NeoForge uses vanilla's model generators instead of its own. I tried to introduce as few changes as possible, but some generated file names have changed due to technical limitations. As part of this, I also decided to leverage Minecraft's BlockFamily class to eliminate some boilerplate code. This can also be used for recipe generation, but I decided not to mess with more than I already had to.
This includes removing unused resource files and renaming the brazier template to be in line with its post-port naming scheme.
Everything just works this time since 26.1.1 is just a hotfix. Also includes updates to datagen, Gradle, NeoForge, and JEI.
|
Oh wow! This is quite a surprise to see! 😄 First off, thank you for the sheer effort put into this. Right now I'm working away on a minor release for Farmer's Delight, so my review may take a few days to do, considering it's a version port. I may do it in multiple passes to catch everything. Also, I have yet to read up on all the changes leading up to 26.1, as I was gonna do it during a future FD port, so this might cause my reviews to take longer still. That said, I will need to make a |
I thought about this during the Copper Age announcement, and my plan was to keep my bars under a different name, rather than remove them. Maybe "Copper Lattice" could work? I could then have freedom to name my custom-appearance bars however I want, and keep "Bars" to the recolored vanilla ones. |
|
Alright, branch I can get back to this PR in the next few days to review it properly, once I'm done with the other mod. Thanks once again for the port! ^^ |
|
Not a problem, take as long as you need. Thanks for making your mods in the first place! |
2 participants
This PR ports The Block Box to Minecraft 26.1.1.
I started this assuming this was going to be simple. It was not. I hope I don't regret having done this.
Here's a list of the major differences between the mod as it is and this port, most of them technical:
hanging_brazier->brazier_hanging).SWORD_DIGitem ability was removed post-1.21.1, so palisade sharpening now checks whether an item falls under the#minecraft:swordtag instead.All the minor datagen output changes mean this PR changes a lot of files, so I'd recommend reviewing the changes per-commit instead of all at once. I tried to cordon most of the datagen output changes to their own commit and also tried to avoid having multiple commits touch the same file where possible. Let me know if you have any questions or would like to make any changes.